-
Notifications
You must be signed in to change notification settings - Fork 491
[sentinel_one] Add Support for Application Risk Data Stream #14910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sentinel_one] Add Support for Application Risk Data Stream #14910
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
alert |
0 | 3703.7 | 3703.7 ( - %) | 👍 |
application |
0 | 9174.31 | 9174.31 ( - %) | 👍 |
application_risk |
0 | 5586.59 | 5586.59 ( - %) | 👍 |
group |
0 | 25000 | 25000 ( - %) | 👍 |
threat |
0 | 2178.65 | 2178.65 ( - %) | 👍 |
activity |
0 | 5200.21 | 5200.21 ( - %) | 👍 |
agent |
0 | 3753.75 | 3753.75 ( - %) | 👍 |
alert |
0 | 3361.34 | 3361.34 ( - %) | 👍 |
application |
0 | 21321.96 | 21321.96 ( - %) | 👍 |
application_risk |
0 | 9066.18 | 9066.18 ( - %) | 👍 |
group |
0 | 34246.58 | 34246.58 ( - %) | 👍 |
threat |
0 | 1719.39 | 1719.39 ( - %) | 👍 |
activity |
0 | 5291.01 | 5291.01 ( - %) | 👍 |
agent |
0 | 4484.3 | 4484.3 ( - %) | 👍 |
@@ -0,0 +1,20 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this ILM policy to work, you would need delete_index
privilege on source indices for kibana_system
role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Here is the PR - elastic/elasticsearch#133793
(Added the application_risk
under CDR packages list that ships a transform and has ILM policy)
..._one/data_stream/application_risk/_dev/test/pipeline/test-application-risk.log-expected.json
Show resolved
Hide resolved
packages/sentinel_one/data_stream/application_risk/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
1. Remove tranform pipeline. 2. Add some ECS mappings in the pipeline. 3. Update event.kind to state from event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but will approve and merge after permissions are merged and backported. #14910 (comment)
@kcreddy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohitjha-elastic , can you also add policy tests for this new data stream?
Please check #15029
For the benchmarks, please ensure to add them in this PR or as part of #14741.
There is also future data stream (Threat Events) that should be handled similarly.
cc: @navnit-elastic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohitjha-elastic, Can you please fix CI issue of naming benchmark files?
/test benchmark fullreport |
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Package sentinel_one - 1.38.0 containing this change is available at https://epr.elastic.co/package/sentinel_one/1.38.0/ |
Proposed commit message
Checklist
changelog.yml
file.How to test this PR locally
Related Issue